Android openDatabase does not call success or error callbacks

[Typhlosaurus]

The android implementation of openDatabase does not report a result, and hence never calls the success, Web SQL does not define an error callback, but SQLitePlugin.js does define one, and it too is not called.

I have not tested this on WP8 or iOS but by inspection the WP8 source should call the callbacks depending on whether valid parameters have been provided (not on actual database open success).

N.B. This can be worked around by immediatly executing any bit of legal SQL and recognising any database open errors.

[nolanlawson]

Yup, this is a known issue. There's even a TODO right in the java code. To fix, it would basically be a one-liner. Pull requests are welcome! :)

[Typhlosaurus]

OK. Will do.

[brody4hire]

Simple open callback test on WP(8) is working, test to open the same database twice does not pass on WP(8) version.

[Typhlosaurus]

My current WP8 build passes the double open test, as well as implementing close and delete. I'm stiull working on testing it in our app, but issue a pull request if that would be useful.

[brody4hire]

On Thu, Aug 21, 2014 at 12:26 PM, Typhlosaurus notifications@github.com
wrote:

My current WP8 build passes the double open test, as well as implementing
close and delete.

This is Really REALLY awesome!

I'm stiull working on testing it in our app, but issue a pull request if
that would be useful.

I took a quick look at the latest changes in your master branch and am
planning to try them out within the next day or so. It is better if you can
issue a pull request at some point purely from a process flow perspective.

Chris

[Typhlosaurus]

Certainly. Is it Ok if I simply give you the whole things as a Pull
request rather trying to work out how to divide it into individual fixes?

Mark

[brody4hire]

On Thursday, August 21, 2014, Typhlosaurus notifications@github.com wrote:

Certainly. Is it Ok if I simply give you the whole things as a Pull
request rather trying to work out how to divide it into individual fixes?

Yes. I will just cherry-pick the commits that I need from the development
branch in your fork so the pull request is mostly a formality (and also a
trigger).

Thanks again for your help. Please make sure that I get your name in the
AUTHORS file when we reach a finishing point with these changes.

Chris

Sent from my mobile

[brody4hire]

Now fixed inmaster (version 1.0.1)