-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
when using onDeviceUI it still tries to create websocket server #3271
Comments
@danielduan, yes. And then we will have all the options to also think how to evolve static build more, by including addons and so on :) |
We should also think whether this should be default option or not. I don't know many RN Storybook users so I can't comment which one should be default behaviour (crashing or skipping websockets when using onDeviceUI). Logic suggests me second option. :D |
@danielduan, lets bring the conversation to the PR. |
This PR was merged into alpha: #3686 . |
Even when you are using onDeviceUI storybook still tries to create websocket server.
Temporary workaround is to write these lines before rendering storybookUI:
const addons = require('@storybook/addons');
addons.setChannel({on: () => {}, emit: () => {}, removeListener: () => {}});
Proper solution would be to add option to skip websocket channel creation (maybe some people want to use both websockets and onDeviceUI at the same time, so we can't disable this functionality, we need to make it opt in).
This shouldn't be difficult to implement.
The text was updated successfully, but these errors were encountered: