using disableWebsockets instead of useWebsockets #3686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested changes
May 30, 2018
Codecov Report
@@ Coverage Diff @@
## master #3686 +/- ##
=======================================
Coverage 41.55% 41.55%
=======================================
Files 458 458
Lines 5058 5058
Branches 849 849
=======================================
Hits 2102 2102
Misses 2451 2451
Partials 505 505
Continue to review full report at Codecov.
|
shilman
approved these changes
May 30, 2018
|
@shilman IDK, some problem with cached dependencies maybe. Corresponding TeamCity build passes |
|
@shilman To make it more deterministic, you can add |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional PR for #3636. As discussed with @shilman it would be better to maintain backwards compatibility with using both onDeviceUI and storybook server at the same time. So I swapped useWebsockets with disableWebsockets. So now if somebody will want to use storybook without server in the app he will have to pass in the disableWebsockets option. This will be described in some documentation when we start separating RN storybook into two parts.