-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add/composition auto disable #11364
Add/composition auto disable #11364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s use {disabled: true}
for consistency with addons and to avoid confusion with accidental falsey values (<- this is something you originally recommended with addons ;))
Good call! |
Uggh sorry this should have been |
@@ -70,6 +70,11 @@ async function getManagerWebpackConfig(options, presets) { | |||
|
|||
if (definedRefs) { | |||
Object.entries(definedRefs).forEach(([key, value]) => { | |||
if (value?.disabled) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (value?.disabled === true) {
oops
Issue: -auto refs are always added users might not want that-
What I did
I added some code that would deal with:
This would remove the ref that was auto-injected