Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update environment declaration in Docker guide.md #2253

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

oyeamjad
Copy link
Contributor

@oyeamjad oyeamjad commented Oct 3, 2024

The space separator between the key and the value has been deprecated; instead, use the format "ENV key=value"

Why is it needed?

While configuring the docker container, I encountered the following warning. To fix this warning, we need to update the docker's build check LegacyKeyValueFormat format.

1 warning found (use docker --debug to expand):
LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 11)

The space separator between the key and the value has been deprecated; instead, use the format "ENV key=value"
@oyeamjad oyeamjad requested a review from pwizla as a code owner October 3, 2024 20:28
@strapi-cla
Copy link

strapi-cla commented Oct 3, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 8:30pm

Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for keeping this page up-to-date, @oyeamjad!

The PR is now approved, merged, should be live on docs.strapi.io in a few minutes, and will be mentioned in the next weekly snapshot release.

@pwizla pwizla merged commit e78c551 into strapi:main Oct 4, 2024
3 checks passed
@pwizla pwizla self-assigned this Oct 4, 2024
@pwizla pwizla added the source: Dev Docs PRs/issues targeting the Developer Docs label Oct 4, 2024
@pwizla pwizla changed the title Update docker.md Update environement declaration in Docker guide.md Oct 4, 2024
@pwizla pwizla changed the title Update environement declaration in Docker guide.md Update environment declaration in Docker guide.md Oct 4, 2024
@pwizla pwizla added the pr: updated content PRs updating existing documentation content label Oct 4, 2024
@pwizla pwizla added this to the 5.1.1 milestone Oct 4, 2024
@pwizla pwizla added the temp: port to doc6 (Temporary label) The content of this PR should be ported to Strapi Docs v6 label Oct 14, 2024
@pwizla pwizla removed the temp: port to doc6 (Temporary label) The content of this PR should be ported to Strapi Docs v6 label Dec 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pr: updated content PRs updating existing documentation content source: Dev Docs PRs/issues targeting the Developer Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants