Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Update related objects with unique_together #362

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

zvyn
Copy link
Contributor

@zvyn zvyn commented Sep 12, 2023

Description

Resolves the issue described in #360: Support updating related objects with unique_together on the foreign key where the data identifies a single object in the database.

Types of Changes

  • Bugfix
  • Enhancement/optimization

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (4cde249) 87.99% compared to head (9f01759) 87.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files          33       33           
  Lines        2940     2941    +1     
=======================================
+ Hits         2587     2588    +1     
  Misses        353      353           
Files Changed Coverage Δ
strawberry_django/mutations/resolvers.py 87.05% <66.66%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bellini666 bellini666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Thank you for this :)

@bellini666 bellini666 merged commit 9ed9c0e into strawberry-graphql:main Sep 12, 2023
@EvSpirit EvSpirit mentioned this pull request Jul 29, 2024
11 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants