tls: support server TLS options #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up the last TLS support PR. this PR is trying to support CLI to set TLS options for Server - Add new command parameters to set TLS options. - We might consider using different TLS options for public/internal, we can easy support it in the future if we need.
mattisonchao
requested review from
merlimat,
coderzc and
RobertIndie
as code owners
lsytj0413
reviewed
Jun 8, 2024
cmd/server/cmd.go
Outdated
| @@ -18,6 +18,8 @@ import ( | |||
| "io" | |||
| "time" | |||
|
|
|||
| "github.com/streamnative/oxia/common/security" | |||
There was a problem hiding this comment.
Run make lint will group github.com/streamnative/oxia's import to same order.
merlimat
approved these changes
Jun 8, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up the last TLS support PR. This PR is trying to support CLI to set TLS options for Server
Modification
Others