Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(coordinator): panic when BadVersion in coordinator #512

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Sep 13, 2024

Motivation

The coordinator will stop all the operations when it stuck in the metadata bad version case. this PR is trying to trigger panic when bad version to help auto-restart. the bad version might caused by many cases:

  1. operator/maintainer update the status config.
  2. another coordinator updated metadata before shutdown.

the coordinator is using lock to ensure all the metadata operation is invoke sequentially. which means we don't have race conditions in the process.

Modification

  • panic directly when met BadVersion

Alternatives

  • Update to the latest version when update metadata get BadVersion. but we have to change some logics to ensure get version before building the new status to avoid unexpected override.

@mattisonchao mattisonchao self-assigned this Sep 13, 2024
@mattisonchao mattisonchao changed the title fix(coordinator): panic when badverion in coordinator fix(coordinator): panic when BadVersion in coordinator Sep 13, 2024
@merlimat merlimat merged commit ad609a0 into main Sep 13, 2024
7 checks passed
@merlimat merlimat deleted the badversion.panic branch September 13, 2024 15:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants