Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Force configmap ownership when updating #540

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Force configmap ownership when updating #540

merged 1 commit into from
Oct 3, 2024

Conversation

merlimat
Copy link
Collaborator

@merlimat merlimat commented Oct 3, 2024

If the status configmap is manually updated with kubectl, the coordinator is not able anymore to update the status.

The error is like:

apply failed with 1 conflict: conflict with "kubectl-edit" using v1: .data.status'

We need to force the coordinator to re-take the ownership of the configmap when trying to make changes.

@merlimat merlimat requested a review from tuteng October 3, 2024 01:11
@merlimat merlimat merged commit 24d5995 into streamnative:main Oct 3, 2024
5 checks passed
@merlimat merlimat deleted the force-configmap-ownership branch October 3, 2024 02:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tuteng tuteng tuteng approved these changes

@mattisonchao mattisonchao Awaiting requested review from mattisonchao mattisonchao is a code owner

@coderzc coderzc Awaiting requested review from coderzc coderzc is a code owner

@RobertIndie RobertIndie Awaiting requested review from RobertIndie RobertIndie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merlimat @tuteng