test(506): regarded as a successful closure when session not found #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsytj0413
requested review from
merlimat,
mattisonchao,
coderzc and
RobertIndie
as code owners
merlimat
reviewed
Feb 21, 2025
server/wal/codec/v1.go
Outdated
| @@ -29,11 +30,7 @@ import ( | |||
| // Size: Length of the payload data | |||
| // Payload: Byte stream as long as specified by the payload size. | |||
|
|
|||
| // Idx File: | |||
There was a problem hiding this comment.
This is removing a valid comment explaining the header format
common/client_pool.go
Outdated
| "io" | ||
| "log/slog" | ||
| "strings" | ||
| "sync" | ||
| "time" | ||
|
|
||
| "google.golang.org/grpc/keepalive" |
There was a problem hiding this comment.
We should move this refactoring (and all the similar) into a separate PR
oxia/options_list.go
Outdated
| @@ -46,8 +46,7 @@ func (u *useIndex) applyRangeScan(opts *rangeScanOptions) { | |||
| opts.secondaryIndexName = &u.indexName | |||
| } | |||
|
|
|||
| // UseIndex let the users specify a different index to follow for the | |||
There was a problem hiding this comment.
Why removing this part of the comment?
server/wal/codec/v2.go
Outdated
| // +--------------+-----------+-----------+-----+ | ||
| // | CRC(4Bytes) | Index(4B) | Index(4B) | ... | | ||
| // +--------------+-----------+-----------+-----+ | ||
| // CRC: 32bit hash computed over the payload using CRC. |
There was a problem hiding this comment.
Same, we shouldn't be removing this comment
|
@merlimat all other changes have been removed（it was auto changed by |
merlimat
approved these changes
Feb 21, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #506