TrackerRegistry #40
TrackerRegistry #40
Conversation
src/utils/TrackerRegistry.js
Outdated
| contractAddress, trackerRegistryConfig, jsonRpcProvider, servers, algorithm = 'sha256', hashRingOptions | ||
| }) => { | ||
| const trackerRegistry = new TrackerRegistry({ | ||
| contractAddress, trackerRegistryConfig, jsonRpcProvider, servers, algorithm, hashRingOptions |
There was a problem hiding this comment.
Is the trackerRegistryConfig really necessary as a param? If it lives in this repo it could just use it by default?
There was a problem hiding this comment.
If the only difference between dev, staging and prod is contractAddress - yes, sure. But who can clarify this?
There was a problem hiding this comment.
Yea, I don't know either... just thinking about the usage of the helper that it's an extra step if it can already assume that it's the contract it will be using. But ok for me to go with this as well.
| ]) | ||
| }) | ||
|
|
||
| test('throw exception if address is wrong (ENS)', async (done) => { |
There was a problem hiding this comment.
FYI async (done) is going away when jest-circus lands:
jestjs/jest#9129
Scheduled for Jest 27:
jestjs/jest#6295
I opened a related issue here:
jestjs/jest#10529
There was a problem hiding this comment.
To get rid of the done the equivalent would probably be this:
await expect(await getTrackerRegistry({
contractAddress: 'address', jsonRpcProvider
})).rejects.toThrow('Error: network does not support ENS')
TrackerRegistryCIintegration tests (usingstreamr-docker-dev)npm scripts