Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat: add Rosé Pine Dawn theme #86

Closed
wants to merge 7 commits into from
Closed

Feat: add Rosé Pine Dawn theme #86

wants to merge 7 commits into from

Conversation

echoriiku
Copy link
Collaborator

  • Added Rosé Pine Dawn theme JSON
  • Added Rosé Pine Dawn CSS for code blocks

Copy link

…ay variant

- Updated the Tokyonight theme to the Tokyonight Moon variant
- Added a new variant, Tokyonight Day, following the namescheme of the Tokyonight project
- Included JSON and CSS files for both variants
- Ensured consistency with the original Tokyonight color scheme
Copy link

JSON and YAML Validation Results

JSON Validation Results

  • ✅ File(s) Passed: 1
  • ❌ File(s) Failed: 4
  • ⏭️ File(s) Skipped: 0

Violations:

[
  {
    "file": "themes/tokyonight-day/v1/theme.json",
    "errors": [
      {
        "path": "/authors/1",
        "message": "must have required property 'name'"
      }
    ]
  },
  {
    "file": "themes/tokyonight-moon/v1/theme.json",
    "errors": [
      {
        "path": "/authors/1",
        "message": "must have required property 'name'"
      }
    ]
  },
  {
    "file": "themes/tokyonight-dark/v1/theme.json",
    "errors": [
      {
        "path": null,
        "message": "Invalid JSON"
      }
    ]
  },
  {
    "file": "themes/tokyonight-light/v1/theme.json",
    "errors": [
      {
        "path": null,
        "message": "Invalid JSON"
      }
    ]
  }
]

YAML Validation Results

  • ✅ File(s) Passed: 3
  • ❌ File(s) Failed: 2
  • ⏭️ File(s) Skipped: 0

Violations:

[
  {
    "file": "themes/tokyonight-dark/v1/theme.json",
    "errors": [
      {
        "path": null,
        "message": "Invalid YAML"
      }
    ]
  },
  {
    "file": "themes/tokyonight-light/v1/theme.json",
    "errors": [
      {
        "path": null,
        "message": "Invalid YAML"
      }
    ]
  }
]

@revsuine
Copy link
Collaborator

If the Rosé Pine Dawn theme is ready to be merged, could you separate out the Tokyo Night changes into a separate branch so it can have a separate PR and we can add the dawn variant without merging the Tokyo Night changes? Also I assume you've spoken to Andres about the Tokyo Night change, but in any case that can be sorted out in the Tokyo Night PR

@echoriiku echoriiku closed this Jul 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants