Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix enabled remote debugging mode in example compose-authz.yml #39

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

mstruk
Copy link
Contributor

@mstruk mstruk commented Mar 17, 2020

Signed-off-by: Marko Strukelj marko.strukelj@gmail.com

Signed-off-by: Marko Strukelj <marko.strukelj@gmail.com>
@mstruk mstruk added this to the 0.4.0 milestone Mar 17, 2020
@mstruk mstruk mentioned this pull request Mar 17, 2020
@scholzj scholzj requested a review from ppatierno March 17, 2020 17:54
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a need but no need to re-review

JAVA_DEBUG_PORT: 5006
#KAFKA_DEBUG: y
#DEBUG_SUSPEND_FLAG: y
#JAVA_DEBUG_PORT: 5006
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need a comment like "uncomment following lines for enabling debugging ... "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be obvious to everyone that removing hashes would activate these settings.
And I prefer to not add comments for obvious things.

@scholzj scholzj merged commit 57c3db8 into strimzi:master Mar 20, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants