Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix and unify redaction rule in report.sh #10770

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fix and unify redaction rule in report.sh #10770

merged 1 commit into from
Oct 30, 2024

Conversation

urbandan
Copy link
Contributor

The pattern and the replacement was different for "password" and "key". This unifies the 2 branches, and makes the pattern more generic - anything with dot separated "password" and "key" words will be covered.

Type of change

Select the type of your PR

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

Please describe your pull request

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@urbandan
Fix and unify redaction rule in report.sh
0d9fc31 
The pattern and the replacement was different for "password" and "key". This unifies the 2 branches, and makes the pattern more generic - anything with dot separated "password" and "key" words will be covered.

Signed-off-by: Daniel Urban <urb.daniel7@gmail.com>
@scholzj scholzj requested a review from fvaleri October 28, 2024 12:58
@scholzj scholzj added this to the 0.45.0 milestone Oct 28, 2024
@scholzj scholzj requested review from scholzj and ppatierno October 28, 2024 12:59
@scholzj
Copy link
Member

scholzj commented Oct 29, 2024

/azp run build

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

scholzj
scholzj approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

fvaleri
fvaleri approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

ppatierno
ppatierno approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@scholzj scholzj merged commit 59d9226 into strimzi:main Oct 30, 2024
13 checks passed
@urbandan urbandan deleted the report_redaction branch October 30, 2024 08:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@scholzj scholzj scholzj approved these changes

@ppatierno ppatierno ppatierno approved these changes

@fvaleri fvaleri fvaleri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.45.0
Development

Successfully merging this pull request may close these issues.
4 participants
@urbandan @scholzj @ppatierno @fvaleri