-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for Kafka 3.9.0 #10812
Add support for Kafka 3.9.0 #10812
Conversation
Signed-off-by: Jakub Scholz <www@scholzj.com>
86a003f
to
5a905db
Compare
/azp run migration |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run upgrade |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run zookeeper-regression |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run feature-gates-regression |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left one question.
public static final String PREVIOUS_FORMAT_VERSION = "3.7"; | ||
public static final String PREVIOUS_PROTOCOL_VERSION = "3.7"; | ||
public static final String PREVIOUS_METADATA_VERSION = "3.7-IV4"; | ||
public static final String PREVIOUS_KAFKA_VERSION = "3.8.0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be 3.8.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not really matter. It just needs to be a previous minor.
Type of change
Description
This PR adds support for Kafka 3.9.0 and removes support for 3.7.0 and 3.7.1.
Checklist