Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix faulty Cruise control healthcheck #10884

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

ShubhamRwt
Copy link
Contributor

@ShubhamRwt ShubhamRwt commented Nov 27, 2024

Type of change

Select the type of your PR

  • Bugfix

Description

This PR fixes #10872. With the addition of -f in the curl command, we now get a separate exit code of 22 in case there is some error/issue. This also fixes the misnamed env var in the code

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com>
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@scholzj scholzj added this to the 0.45.0 milestone Nov 27, 2024
@scholzj
Copy link
Member

scholzj commented Nov 27, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ppatierno ppatierno merged commit ebde1fe into strimzi:main Nov 28, 2024
21 checks passed
OwenCorrigan76 pushed a commit to OwenCorrigan76/strimzi-kafka-operator that referenced this pull request Dec 6, 2024
Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Faulty Cruise Control Healthcheck
3 participants