Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate other Stripe infrastructure to TS #1563

Merged
merged 13 commits into from
Sep 28, 2022

Conversation

anniel-stripe
Copy link
Contributor

@anniel-stripe anniel-stripe commented Sep 26, 2022

Summary

r? @kamil-stripe

Migrating remaining Stripe infrastructure files to TypeScript in a "lazy" manner. This includes the following files:

  • multiPart
  • ResourceNamespace
  • utils.js
  • Webhooks.js
  • crypto/*
  • net/*

See my comments on the .ts files for explanations of why I made a few changes.

@anniel-stripe anniel-stripe force-pushed the anniel-migrate-remaining-infrastructure branch 2 times, most recently from 28d35cf to 84d3ec4 Compare September 26, 2022 16:28
@anniel-stripe anniel-stripe force-pushed the anniel-migrate-remaining-infrastructure branch from 84d3ec4 to 12af083 Compare September 26, 2022 16:37
@anniel-stripe anniel-stripe marked this pull request as ready for review September 26, 2022 16:37
@anniel-stripe anniel-stripe force-pushed the anniel-migrate-remaining-infrastructure branch from 59823d4 to d4f0791 Compare September 26, 2022 16:38
Copy link
Contributor

@kamil-stripe kamil-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL :) I'm going to finish the review later.

@anniel-stripe anniel-stripe force-pushed the anniel-migrate-remaining-infrastructure branch from 5947000 to 651024f Compare September 27, 2022 17:28
Copy link
Contributor

@kamil-stripe kamil-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments. LGTM otherwise.

anniel-stripe and others added 6 commits September 27, 2022 11:51
Co-authored-by: Kamil Pajdzik <99290280+kamil-stripe@users.noreply.github.com>
Co-authored-by: Kamil Pajdzik <99290280+kamil-stripe@users.noreply.github.com>
Co-authored-by: Kamil Pajdzik <99290280+kamil-stripe@users.noreply.github.com>
Co-authored-by: Kamil Pajdzik <99290280+kamil-stripe@users.noreply.github.com>
@anniel-stripe anniel-stripe merged commit 5aae73c into master Sep 28, 2022
@anniel-stripe anniel-stripe deleted the anniel-migrate-remaining-infrastructure branch September 28, 2022 16:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants