-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Refactor integration test #1145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-stripe
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why these tests need an actual HTTP server and can't be done on top of HTTP client mock.
richardm-stripe
commented
Nov 21, 2023
Some of the logic being tested here is logic that is implemented in |
richardm-stripe
added a commit
that referenced
this pull request
Dec 1, 2023
* Refactor integration test * Update tests/test_integration.py
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/test_integration.py is a test file that spins up an HTTP server running in a separate thread and is useful for tests that need to be written at the HTTP level, but I ran into some difficulties when attempting to add a new test here. This PR refactors the test helper a bit to make it more usable:
Queue
and you can assert on the received requests inside the test.TestServer
and (optionally) implementdo_request(n: int)
to return [status_code, headers, body]`