Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add livemode to ThinEvent #1409

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Add livemode to ThinEvent #1409

merged 3 commits into from
Oct 3, 2024

Conversation

helenye-stripe
Copy link
Contributor

@helenye-stripe helenye-stripe commented Oct 3, 2024 •
edited by ramya-stripe
Loading

Why?

This field is being returned from the API. It should be typed in our SDKs.

Changelog

  • Update the class for ThinEvent to include livemode

prathmesh-stripe
prathmesh-stripe reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@prathmesh-stripe prathmesh-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to assert livemode with both true and false values?

@ramya-stripe ramya-stripe merged commit e65fcaa into master Oct 3, 2024
15 checks passed
@ramya-stripe ramya-stripe deleted the helenye-ter branch October 3, 2024 22:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@prathmesh-stripe prathmesh-stripe prathmesh-stripe left review comments

@ramya-stripe ramya-stripe ramya-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helenye-stripe @ramya-stripe @prathmesh-stripe