Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Logging form-data prior to processing form data. #378

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

jkeyes
Copy link
Contributor

@jkeyes jkeyes commented Dec 4, 2017

No description provided.

@jkeyes
Copy link
Contributor Author

jkeyes commented Dec 4, 2017

I don't know why the 2.7.13 build failed. Logs look okay.

@brandur-stripe
Copy link
Contributor

Hey @jkeyes,

We only run flake8 on one version of CI. There's a minor linting error here:

1.00s$ if [[ $TRAVIS_PYTHON_VERSION == '2.7' ]]; then flake8 stripe; fi
stripe/api_requestor.py:335:80: E501 line too long (83 > 79 characters)
The command "if [[ $TRAVIS_PYTHON_VERSION == '2.7' ]]; then flake8 stripe; fi" exited with 1.

@brandur-stripe
Copy link
Contributor

And thanks for the pull! I assume that you submitted this because what you were trying to do with sending a file blows up without the change?

@jkeyes
Copy link
Contributor Author

jkeyes commented Dec 5, 2017

@brandur-stripe Fixed that, thanks for the heads-up. Yeah, file uploads just weren't working for me, I reported on it in #377.

@brandur-stripe
Copy link
Contributor

Thanks for sending your own fix! (And even the test case.)

LGTM.

@brandur-stripe brandur-stripe merged commit f297c21 into stripe:master Dec 5, 2017
@brandur-stripe
Copy link
Contributor

Released as 1.75.3.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants