Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for Subscription Schedules #532

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

remi-stripe
Copy link
Contributor

This adds two new resources: Subscription Schedule and Subscription Schedule Revision. The latter is nested under the former.

This should be ready even though we won't merge until all libraries are ready and stripe-mock supports those new endpoints publicly.

r? @ob-stripe
cc @stripe/api-libraries @alexander-stripe

@remi-stripe remi-stripe force-pushed the remi-add-subscription-schedules branch from 257abfe to 71b6912 Compare February 2, 2019 18:39
@remi-stripe remi-stripe force-pushed the remi-add-subscription-schedules branch 2 times, most recently from 9bd7a8f to b8e59fa Compare February 12, 2019 06:08
@remi-stripe remi-stripe force-pushed the remi-add-subscription-schedules branch from b8e59fa to 1c1d52c Compare February 12, 2019 06:32
@remi-stripe
Copy link
Contributor Author

@ob-stripe stripe-mock has been released, tests are now passing. Can you review so that we can ship tomorrow (or today for you) please? Thank youuuuuuu

Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Feb 12, 2019
@ob-stripe ob-stripe assigned ob-stripe and unassigned remi-stripe Feb 12, 2019
@ob-stripe ob-stripe merged commit c792fde into master Feb 12, 2019
@ob-stripe ob-stripe deleted the remi-add-subscription-schedules branch February 12, 2019 17:08
@ob-stripe
Copy link
Contributor

Released as 2.21.0.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants