New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Deprecate StripeClient#request #1415

Merged

anniel-stripe merged 2 commits into master from anniel-deprecate-stripe-client-request

Jun 12, 2024

Contributor

anniel-stripe commented Jun 12, 2024

Resulting deprecation message reads like this:

NOTE: Stripe::StripeClient#request is deprecated; use the `last_response` property on the returned
resource (see https://github.com/stripe/stripe-ruby?tab=readme-ov-file#accessing-a-response-object
for usage examples) instead. It will be removed on or after 2024-06.

Changelog

Add deprecation warning for StripeClient#request. This helper method will be removed in a future major version. To access response objects, use the last_response property on the returned resource instead. Refer to Accessing a response object in the README for usage details.


          Deprecate StripeClient#request

48d6c26

anniel-stripe requested review from a team and helenye-stripe and removed request for a team

June 12, 2024 20:43


          Remove useless variable assignment

3089f3d

anniel-stripe requested a review from prathmesh-stripe

June 12, 2024 20:45

prathmesh-stripe approved these changes

View reviewed changes

anniel-stripe merged commit 4bdc4e2 into master

14 checks passed

anniel-stripe deleted the anniel-deprecate-stripe-client-request branch

June 12, 2024 22:47

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet