Remove parseSnapshotEvent from StripeClient #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helenye-stripe
force-pushed
the
helenye-pse
branch
from
12d5f39 to
ca26dbc
Compare
helenye-stripe
requested review from
a team and
prathmesh-stripe
and removed request for
a team
ramya-stripe
approved these changes
Oct 1, 2024
prathmesh-stripe
approved these changes
Oct 1, 2024
prathmesh-stripe
added a commit
that referenced
this pull request
Oct 3, 2024
* Support for APIs in the new API version 2024-09-30.acacia (#1458) * remove parseSnapshotEvent (#1463) * Bump version to 13.0.0 * Fixed API Version --------- Co-authored-by: Ramya Rao <100975018+ramya-stripe@users.noreply.github.com> Co-authored-by: Ramya Rao <ramya@stripe.com> Co-authored-by: Prathmesh Ranaut <prathmesh@stripe.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We already have
Stripe::Webhook.construct_eventavailable, and we believe that we may want to unify thin and snapshot event processing on StripeClient eventually. Thus,parseSnapshotEventis not actually useful to add for users.