Initialize instance variable on the getter too #636
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test suite is currently throwing a bunch of warnings from some recent changes I made -- although we initialize `@additive_params` when setting one with `self.additive_object_param`, we don't when we check one with `self.additive_object_param?`. This often isn't a problem because every API resource sets `metadata`, but it is from the test suite and probably for vanilla `StripeObject`s too.
|
(Self-LGTMing this because it's pretty minor.) |
|
Released as 3.12.1. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite is currently throwing a bunch of warnings from some
recent changes I made -- although we initialize
@additive_paramswhensetting one with
self.additive_object_param, we don't when we checkone with
self.additive_object_param?. This often isn't a problembecause every API resource sets
metadata, but it is from the testsuite and probably for vanilla
StripeObjects too.