Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

User-friendly messages for EOFError network errors #859

Merged
merged 2 commits into from
Oct 3, 2019
Merged

User-friendly messages for EOFError network errors #859

merged 2 commits into from
Oct 3, 2019

Conversation

elfassy
Copy link
Contributor

@elfassy elfassy commented Oct 3, 2019

Provide nice errors for more types of network exceptions
EOFError
Errno::ECONNRESET
Errno::ETIMEDOUT
Errno::EHOSTUNREACH

brandur-stripe
brandur-stripe reviewed Oct 3, 2019
View reviewed changes
Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elfassy! Looks quite reasonable to me. Left a couple comments.

lib/stripe/stripe_client.rb Show resolved Hide resolved
test/stripe/stripe_client_test.rb Show resolved Hide resolved
brandur-stripe
brandur-stripe approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@brandur-stripe brandur-stripe merged commit ba7ee5c into stripe:master Oct 3, 2019
@brandur-stripe
Copy link
Contributor

Released as 5.5.0.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@brandur-stripe brandur-stripe brandur-stripe approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elfassy @brandur-stripe @stripe-ci