-
Notifications
You must be signed in to change notification settings - Fork 7
Add Presentation Section to Resources Page #63
Conversation
Signed-off-by: Nora <nora.abdelgadir@ibm.com>
fb578cb
to
7c46605
Compare
@nabdelgadir, thanks for taking up this task!
|
Agreed 👍. For the last point, however, won't that be too much info? Also, I like the version of this patch where there is no whitespace for now. |
@dhmlau I haven't pushed this code, but what do you think about this (pending changing the icon of Raymond's slides to something else)? Currently if you press on any of the cards it links you to the page with the content (e.g. http://www.nodesummit.com/prior-video/node-summit-2018-async-functions-in-practice-miroslav-bajtos/). As for the videos, unfortunately I keep getting this 😢: From vimeo: "The owner of this video has set domain restrictions and you will not be able to embed it on all websites. Please contact the owner if you would like permission to embed this video." |
@nabdelgadir, almost there!
|
13353e2
to
f31b30b
Compare
resources.html
Outdated
<div class="col-md-6"> | ||
<p style="height:6px;"></p> | ||
<div class="text-center" style="justify-content: center"> | ||
<div class="card-2 pres multiple-links" onclick="location.href='https://www.youtube.com/watch?v=i3UW5PhDoQg';"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is kinda hacky because it won't let you put more than one link in a card or else it'll break up the card.
@dhmlau thoughts? |
Looks good. It would be even better if we could make the |
e101942
to
e0ff0de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment - I'd prefer the slides link (from Janny's tile) will open a new tab, just like clicking the other tile. Other than that, LGTM.
Please squash the commits before merging. Thanks!
Signed-off-by: Nora <nora.abdelgadir@ibm.com>
e0ff0de
to
7edc105
Compare
Closes #61.
What the new section looks like:
An alternate implementation to get rid of the white space until we have more content: