-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for various Ilograph features #332
Comments
My initial though would be a comma-separated list of imports in a workspace property named
I've added support for icons, which will use a property named
What would this be used for? |
|
For 3, I was diagramming a couple services my team owns, one upstream service, and one downstream. All the services are doing some async event handling. Each service has an SNS topic, SQS queue, and Lambda to process messages. I repeated this 4 times, which is fine, but having an abstract definition of an Ilograph resource which I can then say everything else is an Unrelated, but I appreciate you acting so quickly to implement these changes. A talk you gave on C4 came up in my YouTube recommended. I found the idea of models as code very compelling. I was playing around with it last week as a proof of concept. I am sold. Now I am going to pitch to my team a requirement to add C4 models with every commit that adds new functionality. |
I typed out an explanation and only upon expanding on this idea did I realize it isn't useful, as the relationships would not be able to be defined in Structurizr DSL. The only way would be to also add support for the So, the only use of adding this would be to support importing resources from Ilograph's standard library. Currently, the only thing that's there is a theme for AWS resources. They claim this will expand soon, but given nothing has been added there in 3 years, I am doubtful. Given that there is already support for colors and now icons, the same theming can be done from Structurizr. I'm much less concerned about this specific feature now. I was initially intending to use it to do some abstraction in a separate file, which I would then import, but this won't work based on what I explained in the first paragraph. |
I came to the same conclusion, but I don't use Ilograph, so wasn't sure if I'd missed something. Thanks for the info! |
Description
Currently, the Ilograph exporter lacks support for some Ilograph features. Most notably to me:
I believe these could be supported through the
properties
field inWorkspace
andElement
. It seems like there is precedent for using properties to support features specific to an export type based on this line in the PlantUML exporter.To support
icon
andinstanceOf
, there could simply be a check for those strings in theproperties
map in thewriteElement
method. Supporting imports is harder, as each Ilograph import has 2 properties,from
andnamespace
. The way it needs to be formatted in the output is like this:My best thought right now would be to just have a check for a property with key
"imports"
and a value of"- from: ilograph/aws\nnamespace: AWS"
. This looks kinda ugly, but I cannot think of a better way given the class structure of the structurizr library. Happy to hear if anyone has any better ideas. I'm more than willing to implement this feature myself, as it is something I would really value.Priority
I'm willing to add this feature myself and raise a PR (please confirm approach first)
More information
No response
The text was updated successfully, but these errors were encountered: