Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Rules for context array should be get values with ->getConstantArrays() #57

Closed
sasezaki opened this issue Oct 21, 2023 · 0 comments · Fixed by #62
Closed

Rules for context array should be get values with ->getConstantArrays() #57

sasezaki opened this issue Oct 21, 2023 · 0 comments · Fixed by #62
Assignees
@sasezaki
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@sasezaki
Copy link
Member

sasezaki commented Oct 21, 2023 •
edited
Loading

  • ContextKeyRule
  • ContextRequireExceptionKeyRule
    • seems useless. currently already variable array is supported, and union type is not supported. union type support is meaningless for this rule.
  • also PlaceholderCorrespondToKeysRule

current implementations only checks dynamic parameter $logger->info('foo', ['key' => 'bar']);.
Rules should be checked with phpdoc parameter, method scope array variable( $context = ['key' => 'bar']; $logger->info('foo', $context); )
@sasezaki sasezaki added enhancement New feature or request good first issue Good for newcomers bug Something isn't working labels Oct 21, 2023
@sasezaki sasezaki self-assigned this Oct 22, 2023
sasezaki added a commit to sasezaki/sfp-phpstan-psr-log that referenced this issue Oct 22, 2023
@sasezaki
ContextKeyRule - Handle context array by constant-array struggle-for-…
2525a31 
…php#57
@sasezaki sasezaki mentioned this issue Oct 22, 2023
Merged
sasezaki added a commit to sasezaki/sfp-phpstan-psr-log that referenced this issue Oct 22, 2023
@sasezaki
PlaceholderCorrespondToKeysRule - Handle context array by constant-ar…
569a077 
…ray struggle-for-php#57
sasezaki added a commit that referenced this issue Oct 22, 2023
@sasezaki
Merge pull request #62 from sasezaki/context-constant-arrays
7f1e03e 
Handle context array by constant-array #57
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@sasezaki sasezaki

Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle context array by constant-array #57 sasezaki/sfp-phpstan-psr-log
1 participant
@sasezaki