Fixes the package when using config:cache #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 6, 2017 16:56
You cannot use `env()` inside your application code when using cached configs - which is outlined here https://laravel.com/docs/5.4/configuration#configuration-caching By externalising the `env(‘KICKBOX_API_KEY’)` to a config variable, it allows it to be cached by laravel.
|
@stuyam Any chance we could look at getting this merged? Many thanks :) |
|
Wow yeah, seemed to have missed this sorry! yikes! |
|
@OwenMelbz released in v1.0.1! If you have the chances to open another PR on the phone validator package that would be sick and I would gladly merge! https://github.com/stuyam/laravel-phone-validator |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You cannot use
env()inside your application code when using cachedconfigs - which is outlined here
https://laravel.com/docs/5.4/configuration#configuration-caching
By externalising the
env(‘KICKBOX_API_KEY’)to a config variable, itallows it to be cached by laravel.