Skip to content
This repository was archived by the owner on Feb 4, 2023. It is now read-only.

Add LinkColumn #839

Merged
merged 2 commits into from
May 10, 2019
Merged

Conversation

philippemilink
Copy link
Contributor

Hi,
The LinkColumn allows to display links in datatable cells.

Requires PRs #837.

* allows to display links in datatable.
@stephanvierkant
Copy link
Collaborator

stephanvierkant commented Aug 24, 2019

@philippemilink I really don't understand why I didn't see this before, but there is some inconsistency between the LinkColumn and the interface it implements:
\Sg\DatatablesBundle\Datatable\Column\ColumnInterface::renderToMany(array &$row)
\Sg\DatatablesBundle\Datatable\Column\LinkColumn::renderToMany(array &$row, array &$resultRow):

Compile Error: Declaration of Sg\DatatablesBundle\Datatable\Column\LinkColumn::renderSingleField(array &$row, array &$resultRow) must be compatible with Sg\DatatablesBundle\Datatable\Column\ColumnInterface::renderSingleField(array &$row)

What are your thoughts?

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants