Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove unitless line height #121

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Remove unitless line height #121

merged 1 commit into from
Oct 4, 2019

Conversation

jacobp100
Copy link
Contributor

Since we're doing a major release anyway, I want to remove this, as it does the wrong thing in the following case,

const Component = styled(View)`
  font: 16px/1.5 system;
`

const IncorrectLineHeight = () => (
  <Component style={{ fontSize: 24 }} />
)

@jacobp100 jacobp100 requested a review from kristerkari October 3, 2019 20:15
kristerkari
kristerkari approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@kristerkari kristerkari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@jacobp100 jacobp100 merged commit 26f4b49 into master Oct 4, 2019
@jacobp100 jacobp100 deleted the remove-unitless-lineheight branch October 4, 2019 07:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kristerkari kristerkari kristerkari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobp100 @kristerkari