Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add comment message for IPSet rules #3105

Open
tpantelis opened this issue Jul 26, 2024 · 1 comment
Open

Add comment message for IPSet rules #3105

tpantelis opened this issue Jul 26, 2024 · 1 comment
Assignees
@tpantelis
Labels
enhancement New feature or request priority:low stale

Comments

@tpantelis
Copy link
Contributor

tpantelis commented Jul 26, 2024 •
edited
Loading

What would you like to be added:

The ipset CLI supports adding a comment to a rule for informational purposes: https://ipset.netfilter.org/ipset.man.html (please search for comment). When the rules are listed, the output will include the comment.

We can add support for this in https://github.com/submariner-io/submariner/blob/devel/pkg/ipset/ipset.go.

Why is this needed:

For debugging.
@tpantelis tpantelis added the enhancement New feature or request label Jul 26, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Backlog Jul 26, 2024
tpantelis added a commit to tpantelis/submariner that referenced this issue Jul 26, 2024
@tpantelis
Remove TODO in pkg/ipset.go
172dacf 
Issue submariner-io#3105
has been created to track this instead.

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
aswinsuryan pushed a commit that referenced this issue Jul 26, 2024
@tpantelis @aswinsuryan
Remove TODO in pkg/ipset.go
a39a654 
Issue #3105
has been created to track this instead.

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
@tpantelis tpantelis self-assigned this Oct 19, 2024
@tpantelis tpantelis moved this from Backlog to Next Version Candidate in Backlog Oct 28, 2024
@maayanf24 maayanf24 removed this from Backlog Oct 29, 2024
@maayanf24 maayanf24 moved this to Todo in Submariner 0.20 Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 27, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@tpantelis tpantelis

Labels
enhancement New feature or request priority:low stale
Projects
Submariner 0.20
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tpantelis @maayanf24