Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Auth Password Storage Mechanism #68

Merged
merged 8 commits into from
Jan 1, 2024
Merged

Auth Password Storage Mechanism #68

merged 8 commits into from
Jan 1, 2024

Conversation

subroseio
Copy link
Contributor

@subroseio subroseio commented Dec 26, 2023

Switching bcrypt in favour for password encryption
bcrypt was causing ~60ms delay per call as it's unsuitable for API credential management (it's slow on purpose) switched over to encryption to speed things up

Before
Results over 1000 records:
+-------+----------+-----------+----------+-------+----------+----------+
| | Min (ms) | Mean (ms) | Max (ms) | Std | P95 (ms) | P99 (ms) |
+-------+----------+-----------+----------+-------+----------+----------+
| Write | 76.79 | 120.5 | 234.36 | 24.38 | 164.98 | 189.21 |
| Read | 75.09 | 115.99 | 239.63 | 22.77 | 159.63 | 188.74 |
+-------+----------+-----------+----------+-------+----------+----------+

After
Results over 1000 records:
+-------+----------+-----------+----------+------+----------+----------+
| | Min (ms) | Mean (ms) | Max (ms) | Std | P95 (ms) | P99 (ms) |
+-------+----------+-----------+----------+------+----------+----------+
| Write | 2.86 | 11.96 | 49.76 | 6.59 | 23.23 | 35.65 |
| Read | 2.04 | 11.21 | 57.7 | 6.41 | 22.54 | 31.25 |
+-------+----------+-----------+----------+------+----------+----------+

PacoNelos
PacoNelos previously approved these changes Dec 28, 2023
@PacoNelos PacoNelos merged commit 1adad27 into main Jan 1, 2024
1 check failed
@PacoNelos PacoNelos deleted the auth-reimplement branch January 1, 2024 23:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants