WIP Fallout from 1.0 branch and PRODUCT_NAME fiasco #48

sudara · 2023-09-01T12:04:21Z

This fixes a handful of fallout from the last big 1.0 PR.

Resolves both issues in installer.iss & deprecated macOS actions #30
Export .env at runtime with config to prevent duplication with GA. Fixes PROJECT_NAME and PRODUCT_NAME should be passed into the GitHub Action #45
Fixes PROJECT_NAME / PRODUCT_NAME Disambiguation in GA config #50
Changes the PRODUCT_NAME of the Pamplejuce plugin to Pamplejuce Demo to ensure spaces will always be happy in GA config
Fixes InnoSetup should read PRODUCT_NAME from ENV/CMake #47
Globs all assets from assets/ dir by default
Fixes macOS include not being included
Adds example EULA (currently just used in Windows Installer)

sudara added 4 commits September 1, 2023 02:18

Workflow PRODUCT_NAME is actually ARTIFACT_NAME

6e27949

Include macOS file (this was forgotten in the 1.0 branch)

39dc745

Try to pass ENV vars to GitHub Actions

d99d76c

set ENV vars from CMake in GA

ee40912

sudara marked this pull request as ready for review September 1, 2023 12:13

sudara and others added 25 commits September 1, 2023 17:23

IPP must link to SharedCode as INTERFACE

2672ce1

Write out .pamplejuce_env in CI

95313cf

Read in .pamplejuce.env and concat to GITHUB_ENV

1b80d61

Grab ENV after configure step

19e165e

Typo: .pamplejuce.env

4c97072

The env is is the Builds dir, of course

bfa61f9

Stick the .env at the root of the project

d647dea

CI is equal to "true", not 1. Just test for presence.

1f668d6

Automatically glob assets for inclusion from /assets folder

a1c94d2

I was lied to, CMAKE_CURRENT_LIST_DIR isn't always a list file!

945b90d

Use .env as the ENV file name

6bc27a1

Debug .env

c24d700

env_file needs quotes

dc4b70c

Test out a PRODUCT_NAME with spaces

c89f0ae

Fix test depending on plugin name

7c605cd

Add an appropriate EULA for the product

cbe2664

Rename LICENSE to EULA to help differentiate from Pamplejuce proper

47678fa

Typo, forgot the $ in $GITHUB_ENV

720a531

Properly set the bash variables

fa5f019

Reading in .env needs its own step

0e18800

Use PRODUCT_NAME in env vars

217fc26

Add rest of PROJECT/PRODUCT disambiguation (Thx @The-Him)

9724c8e

Fixes #30 and a few other PRODUCT_NAME issues

50a490d

More quotes missing

e11f8e8

More missing quotes on Mac

5ef10b7

Keep dmg hardcoded for now

a172d11

sudara merged commit 1802b34 into main Sep 4, 2023

Provide feedback