chore: [#116]Validate the syntax in the Code Editor #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate the syntax in the Code Editor Logic- 1)For validating instruction format - sliced the complete instruction with " " - the arguments following the instruction(if any) must contain ":" 2) For validating nesting format - Keeping track of count of previous indentations in `previousIndentations` - Keeping track of count of current indentations in `currentIndentations` - if the `currentIndentations > previousIndentations` then `currentIndentations` must be equal to `previousIndentations+2` - if `currentIndentations <= previousIndentations` nesting is valid - if `currentIndentations == units.length` there is no instruction in the current line, return `false`
|
fixed in #180 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #116
Validate the syntax in the Code Editor
Logic-
previousIndentationscurrentIndentationscurrentIndentations > previousIndentationsthencurrentIndentationsmust be equal topreviousIndentations+2currentIndentations <= previousIndentationsnesting is validcurrentIndentations == units.lengththere is no instruction in the current line, returnfalse