Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Needless double GET of favicon #650

Open
quozl opened this issue Jan 20, 2025 · 2 comments · May be fixed by #652
Open

Needless double GET of favicon #650

quozl opened this issue Jan 20, 2025 · 2 comments · May be fixed by #652

Comments

@quozl
Copy link
Contributor

quozl commented Jan 20, 2025

On loading the site does GET favicon twice, once because of the link tag, and once because of js/main.fs.

Reduce to one or zero GETs.
@ad1tyayadav
Copy link

I'm working on this

@ad1tyayadav ad1tyayadav mentioned this issue Jan 20, 2025
Closed
ad1tyayadav added a commit to ad1tyayadav/www that referenced this issue Jan 20, 2025
@ad1tyayadav
Fixes/sugarlabs#650 Needless double GET of favicon
dd3c09e
@ad1tyayadav ad1tyayadav linked a pull request Jan 20, 2025 that will close this issue
Open
@ad1tyayadav
Copy link

@quozl hey can you please review this PR #652

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes/#650 needless favicon fetch fix ad1tyayadav/www
2 participants
@quozl @ad1tyayadav