Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: test Node.js 6, 8, 10 and 11 #64

Merged
merged 1 commit into from
Jan 1, 2019
Merged

ci: test Node.js 6, 8, 10 and 11 #64

merged 1 commit into from
Jan 1, 2019

Conversation

DanielRuf
Copy link
Contributor

Node.js 6, 8 and 10 are current LTS branches and 11 is stable.

See https://github.com/nodejs/Release/blob/master/README.md

Node.js 4 already reached its EOL.

@DanielRuf
Copy link
Contributor Author

DanielRuf commented Nov 6, 2018

Some breaking unit tests on Node.js 11.

See https://travis-ci.org/suguru03/neo-async/jobs/451312228#L1905-L1907

  1) #detectLimit should not get item:
      AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected
  [
    2
+   8
+   4
-   4
-   8
  ]
      + expected - actual
       [
         2
      +  4
         8
      -  4
       ]
      
      at test/collections/test.detect.js:1152:14

@suguru03
Copy link
Owner

suguru03 commented Nov 6, 2018

Thanks for the PR!
I'll look into it. 🙂

It may be a Node.js issue, I'm waiting for the response now.

@suguru03
Copy link
Owner

Related to nodejs/node#24203

@DanielRuf
Copy link
Contributor Author

Related to nodejs/node#24203

Good to know. Let me know when there is a new patch release so I can trigger a new build.

@codecov-io
Copy link

codecov-io commented Jan 1, 2019

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #64     +/-   ##
=======================================
  Coverage     100%   100%             
=======================================
  Files           2      2             
  Lines        3316   4514   +1198     
=======================================
+ Hits         3316   4514   +1198
Impacted Files Coverage Δ
lib/async.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0afaac...160c04c. Read the comment docs.

@suguru03 suguru03 merged commit c51f3ca into suguru03:master Jan 1, 2019
@DanielRuf DanielRuf deleted the ci/test-nodejs-6-8-10-11 branch March 17, 2019 19:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants