♻️(api) refactor getting versions to expose pagination #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaccoud
added
bug
sampaccoud
force-pushed
the
fix-404-when-getting-versions
branch
from
8aa042d to
1d67828
Compare
AntoLC
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Works great!
I am just wondering if it is necessary to provide the latest version (the current one so).
Is it easy to add a filter on it on the backend side?
Otherwise, on the frontend side I have to apply a filter to display only the version where is_latest is at false
sampaccoud
force-pushed
the
fix-404-when-getting-versions
branch
from
1d67828 to
00e851b
Compare
It was not so trivial but I pushed a fixup for your review! 😅 |
sampaccoud
force-pushed
the
fix-404-when-getting-versions
branch
from
00e851b to
f527df1
Compare
sampaccoud
force-pushed
the
fix-404-when-getting-versions
branch
from
f527df1 to
0ebba30
Compare
Getting versions was not working properly. Some versions returned were not accessible by the user requesting the list of available versions. We refactor the code to make it simpler and let the frontend handle pagination (load more style).
sampaccoud
force-pushed
the
fix-404-when-getting-versions
branch
from
0ebba30 to
ee6f34b
Compare
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Getting versions was not working properly. Some versions returned were not accessible by the user requesting the list of available versions.
Proposal
We refactor the code to make it simpler and let the frontend handle pagination (load more style).