✨(backend) add full_name and short_name to user model and API #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaccoud
added
enhancement
sampaccoud
force-pushed
the
add-name-to-user
branch
2 times, most recently
from
ea07469 to
ae036dd
Compare
AntoLC
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Top!
Can we add the names here as well, with names can be sometime empty?
https://github.com/numerique-gouv/impress/blob/e6425066757c3afac2325096d70aad41846b9b1f/src/backend/demo/management/commands/create_demo.py#L115-L125
sampaccoud
force-pushed
the
add-name-to-user
branch
from
ae036dd to
c9b8206
Compare
The full_name and short_name field are synchronized with the OIDC token upon each login.
sampaccoud
force-pushed
the
add-name-to-user
branch
from
c9b8206 to
f65d3c1
Compare
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We need to add a name for our users instead of showing their email addresses.
Proposal
Add a
short_nameandfull_namefields as per the best international practice.The full_name and short_name field are synchronized with the OIDC token upon each login. The fields from the token that are synchronized with the the
short_nameandfull_namefields are configurable (in our casefirstname+lastnamegoes tofull_name, whilefirst_namegoes toshort_name)