update header to stanford header #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnoneill
force-pushed
the
bl8-header
branch
2 times, most recently
from
6dcd155 to
fd2cceb
Compare
jcoyne
requested changes
Aug 1, 2024
jcoyne
requested changes
Aug 1, 2024
dnoneill
force-pushed
the
bl8-header
branch
4 times, most recently
from
e7dfcbb to
16be3ac
Compare
dnoneill
commented
Aug 1, 2024
| @@ -1,3 +1,7 @@ | |||
| @import 'bootstrap/scss/bootstrap'; | |||
| @import 'blacklight-frontend/app/assets/stylesheets/blacklight/blacklight'; | |||
| @import '@geoblacklight/frontend/app/assets/stylesheets/geoblacklight/geoblacklight'; | |||
| @import '@geoblacklight/frontend/dist/stylesheets/geoblacklight/geoblacklight'; | |||
There was a problem hiding this comment.
This might need to change but with v3 it is what works
dnoneill
commented
Aug 1, 2024
| </script> | ||
| <% end %> | ||
|
|
||
| <link rel="stylesheet" href="/sul-components/v2024-08-01/styles/sul.css" /> |
There was a problem hiding this comment.
This is just the blacklight base with this link added.
dnoneill
commented
Aug 1, 2024
| <%= content_for(:skip_links) %> | ||
| </div> | ||
| </nav> | ||
| <%= render blacklight_config.header_component.new(blacklight_config: blacklight_config) %> |
There was a problem hiding this comment.
Only other change is using the component instead of the partial, figured it was clearer.
jcoyne
requested changes
Aug 1, 2024
jcoyne
approved these changes
Aug 1, 2024
thatbudakguy
reviewed
Aug 2, 2024
Comment on lines
+5
to
+7
| .palo-alto-base { | ||
| --bs-dark-rgb: 23, 94, 84; | ||
| } |
There was a problem hiding this comment.
can we put this in our own style.css? I think this stylesheet is just for GBL stuff
There was a problem hiding this comment.
@thatbudakguy I moved this to the application.css file in the PR for the footer.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1053