Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bl8 georeference alert #1161

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Bl8 georeference alert #1161

merged 1 commit into from
Aug 13, 2024

Conversation

dnoneill
Copy link
Contributor

@dnoneill dnoneill commented Aug 12, 2024

Screenshot 2024-08-12 at 4 32 11 PM

closes #1137

@dnoneill dnoneill marked this pull request as ready for review August 12, 2024 20:30
@dnoneill dnoneill force-pushed the bl8-georeference-alert branch 2 times, most recently from 0ab1345 to 7a8837f Compare August 12, 2024 20:31
@thatbudakguy thatbudakguy linked an issue Aug 12, 2024 that may be closed by this pull request
@marlo-longley
Copy link
Contributor

This looks good! I noticed that we don't have any fixture data with the field gbl_georeferenced_b set. Would it be worth adding this field to an appropriate fixture .json and adding a test?

@dnoneill dnoneill force-pushed the bl8-georeference-alert branch from 7a8837f to 697c3bb Compare August 13, 2024 16:00
@dnoneill dnoneill requested a review from marlo-longley August 13, 2024 16:00
@dnoneill dnoneill force-pushed the bl8-georeference-alert branch from 697c3bb to 9c24abf Compare August 13, 2024 16:01
@dnoneill dnoneill merged commit 1d5c3a1 into bl8 Aug 13, 2024
3 checks passed
@dnoneill dnoneill deleted the bl8-georeference-alert branch August 13, 2024 16:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Show an alert if the item is not georeferenced
2 participants