Respect webspaces when calculating the maximum number of sitemap pages #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think @xabbuh is right here and there is a bug. This should be taken into account. |
TheCadien
approved these changes
Jun 5, 2023
alexander-schranz
approved these changes
Jun 7, 2023
alexander-schranz
force-pushed
the
bugfix/max-page-webspaces
branch
from
37ae1b7 to
f50389b
Compare
alexander-schranz
changed the title
|
Thx @xabbuh |
alexander-schranz
added
the
bug
wachterjohannes
pushed a commit
to wachterjohannes/SuluArticleBundle
that referenced
this pull request
Dec 14, 2023
sulu#642) * respect webspaces when calculating the maximum number of sitemap pages * Fix baseline errors --------- Co-authored-by: Alexander Schranz <alexander@sulu.io>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
When articles are collected for the sitemap, the provider restricts them to the articles that are associated with the webspaces of the current host. However, this restriction is not applied when the number of pages is being calculated.
Why?
Example Usage
BC Breaks/Deprecations
To Do