Add example and default value to radio buttons #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
changed the title
Dynamic/Types/ChoiceTrait.php
Outdated
| @@ -39,6 +39,8 @@ private function getChoiceOptions( | |||
| FormFieldTranslation $translation, | |||
| array $options | |||
| ): array { | |||
| $options['placeholder'] = false; | |||
There was a problem hiding this comment.
if no empty value should be displayed the content manager need to set the value the required flag. Will remove this change.
alexander-schranz
approved these changes
Apr 1, 2022
|
@Quehnie Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Content managers can add a default value and a placeholder for radiobuttons.
Why?
If nothing is set there is a "None" value shown as default.
Example Usage
Create a new form with radio buttons.
BC Breaks/Deprecations
Existing "None" selections will dissapear.EDIT: this is expected and can be avoided by the content manager when selectingRequiredon the radio buttons, or any other choice.