-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add toolbar action for creating copy of current form to edit view #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasnatter
commented
Feb 2, 2022
Controller/FormController.php
Outdated
$data['title'] = $data['title'] . ' (2)'; | ||
|
||
/** @var array{ options: \stdClass|mixed[] } $field */ | ||
foreach ($data['fields'] as &$field) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is needed because the getApiEntity
method returns an empty \stdClass
here:
SuluFormBundle/Controller/FormController.php
Line 367 in c3908bd
$fieldData['options'] = new \stdClass(); // convert options to "{}" |
niklasnatter
commented
Feb 2, 2022
alexander-schranz
approved these changes
Apr 1, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This pull requests adds a toolbar action for creating a copy of the current form to the form edit view. It depends on the toolbar action implemented in sulu/sulu#6475.
Why?
See #151