Skip to content

Update ImageInput component prop types #2067

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

connor-baer
Copy link
Member

Effectively reverts #1970.

Purpose

The ImageInput accepts a component prop to render the selected image. This image should be hidden from screen reader users. aria-hidden is more appropriate than alt since it works for any HTML element, not just img.

Approach and changes

  • Update the component prop's function signature

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer requested a review from a team as a code owner April 27, 2023 09:47
@connor-baer connor-baer requested review from pdrmdrs and removed request for a team April 27, 2023 09:47
@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

🦋 Changeset detected

Latest commit: 86540e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview Apr 27, 2023 9:47am

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #2067 (86540e2) into next (06faaae) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2067      +/-   ##
==========================================
- Coverage   96.81%   96.77%   -0.04%     
==========================================
  Files         248      248              
  Lines       22383    22384       +1     
  Branches     2117     2117              
==========================================
- Hits        21669    21662       -7     
- Misses        703      709       +6     
- Partials       11       13       +2     
Impacted Files Coverage Δ
...es/circuit-ui/components/ImageInput/ImageInput.tsx 91.83% <100.00%> (-1.59%) ⬇️

@connor-baer connor-baer merged commit 4f78573 into next Apr 27, 2023
@connor-baer connor-baer deleted the feature/imageinput-component-props branch April 27, 2023 13:43
This was referenced Aug 8, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants