Motorbike icon added #2937
Merged
Motorbike icon added #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6a408a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
connor-baer
requested changes
Feb 4, 2025
packages/icons/manifest.json
Outdated
| @@ -1868,6 +1868,11 @@ | |||
| "category": "Product and feature", | |||
| "size": "24" | |||
| }, | |||
| { | |||
| "name": "motorbike", | |||
| "category": "Product and feature", | |||
There was a problem hiding this comment.
The icon is in the "Miscellaneous" category in Figma. Let's match that here (and re-order the entry accordingly).
There was a problem hiding this comment.
Icons must use currentColor instead of hard-coded hex values as the fill or stroke color (see the Contributing Icons docs).
|
Size Change: +9 B (0%) Total Size: 702 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2937 +/- ##
=======================================
Coverage 87.60% 87.60%
=======================================
Files 228 228
Lines 13058 13058
Branches 1760 1760
=======================================
Hits 11440 11440
Misses 1561 1561
Partials 57 57 |
connor-baer
approved these changes
Feb 5, 2025
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Motorbike icon is needed in the ze-dashboard but it is not in the design system library.
Approach and changes
Definition of done