fix keyboard interaction bug for the rows of the Table component #2985
+22
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f4ff8f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +152 B (+0.02%) Total Size: 708 kB
ℹ️ View Unchanged
|
sirineJ
force-pushed
the
table-row-keydown
branch
from
1bfc51a to
f4ff8f6
Compare
sirineJ
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2985 +/- ##
=======================================
Coverage 87.63% 87.64%
=======================================
Files 229 229
Lines 13082 13091 +9
Branches 1764 1767 +3
=======================================
+ Hits 11464 11473 +9
Misses 1561 1561
Partials 57 57
🚀 New features to boost your workflow:
|
connor-baer
reviewed
Mar 12, 2025
| const onClick = vi.fn(); | ||
| render(<TableRow onClick={onClick}>{children}</TableRow>); | ||
| const rowEl = screen.getByRole('row'); | ||
|
|
||
| rowEl.focus(); | ||
| await userEvent.type(rowEl, '{enter}'); | ||
| await userEvent.type(rowEl, ' '); | ||
| await userEvent.keyboard('{Enter}'); |
There was a problem hiding this comment.
This should use the key from the test matrix above.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-977
Description
There are interactive table rows that receive focus when navigating the page using a keyboard. However, it cannot be
activated using Enter or Space.
As such, keyboard users may not be able to operate those interactive elements.
Approach and changes
Add a keydown event handler than triggers the onClickcallback when a row receives a Enter or Space key event.
Definition of done