Ctrl+C/Ctrl+V が効かなくなる問題を修正 #1116
Conversation
WalkthroughThe changes enhance the copy and paste functionality in the main application component. A new hidden Changes
Sequence Diagram(s)sequenceDiagram
participant M as Main Component
participant H as Hotkey Installer
participant U as User
participant S as Store
Note over M: On mounted lifecycle hook
M->>H: installHotKeyForMainWindow(clipboard)
Note over M: Hotkeys registered
U->>M: Triggers copy (keyboard/hidden button)
M->>S: onCopy() → store.copyRecordKIF()
U->>M: Triggers paste (keyboard/hidden button)
M->>S: onPaste() → store.showPasteDialog()
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1116 +/- ##
=======================================
Coverage 78.47% 78.47%
=======================================
Files 122 122
Lines 15921 15921
Branches 2607 2607
=======================================
Hits 12494 12494
Misses 3408 3408
Partials 19 19 ☔ View full report in Codecov by Sentry. |
sunfish-shogi
force-pushed
the
fix-copy-paste-issue
branch
from
0c963b7 to
7c041fd
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/renderer/view/main/ControlPane.vue (2)
5-5: Changed rendering directive from v-show to v-ifThe change from
v-showtov-ifaffects how this control group is handled in the DOM. Withv-if, the element is completely removed from the DOM when the condition is false, rather than just being hidden with CSS (v-show).This change likely helps with the Ctrl+C/Ctrl+V issue by reducing DOM complexity when elements aren't needed, but consider documenting this architectural decision in a comment to explain why
v-ifis preferred overv-showin this case.
170-170: Changed rendering directive from v-show to v-ifSimilar to the previous change, switching from
v-showtov-iffor the second control group changes its DOM behavior.This is consistent with the change made to the first control group. Both changes together help streamline the DOM structure when certain controls aren't needed, which can improve event handling for keyboard shortcuts.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/renderer/App.vue(2 hunks)src/renderer/view/main/ControlPane.vue(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (6)
src/renderer/App.vue (6)
55-60: Added workaround for clipboard operation issueThe implementation adds hidden buttons with hotkey attributes to handle copy/paste operations, addressing the issue mentioned in the comments where normal copy/paste events weren't being captured properly.
This is a good workaround for the copy/paste functionality issue. The comments clearly explain the problem and reference the related issue #1114. The hidden div with buttons provides a clean way to capture keyboard shortcuts without affecting the UI.
65-65: Added ref import from VueAdded
refto the import list from Vue to support the clipboard reference.
105-105: Added clipboard referenceCreated a reference to connect with the hidden div in the template.
The reference is properly defined and will be used to install hotkeys for the clipboard operations.
113-119: Implemented copy and paste handlersAdded functions to handle copy and paste actions by calling appropriate store methods.
The implementation is clean and straightforward.
onCopycallsstore.copyRecordKIF()andonPastecallsstore.showPasteDialog(), which appear to be the correct operations for these actions.
122-122: Updated hotkey installationModified the
onMountedhook to install hotkeys for the main window using the clipboard reference.The hotkey installation is correctly placed in the
onMountedlifecycle hook to ensure it's set up when the component is mounted. Using the clipboard reference connects it to the hidden buttons added in the template.
55-122:❓ Verification inconclusive
Verify the clipboard functionality works across different platforms
The implementation uses the Mod+C and Mod+V shortcuts, which should translate to Ctrl+C/Ctrl+V on Windows/Linux and Cmd+C/Cmd+V on macOS.
Since the PR specifically mentions fixing an issue where Ctrl+C/Ctrl+V don't work, it's important to verify this fix works properly across different operating systems and browsers. Consider testing the following:
- Does it work on Windows, macOS, and Linux?
- Does it work in different browsers if this is a web application?
- Are there any edge cases where the clipboard operations might still fail?
🏁 Script executed:
#!/bin/bash # Check if the hotkey module properly handles platform-specific key bindings # Look for platform-specific code in the hotkey implementation rg -A 10 "platform|os|mac|windows|linux" src/renderer/devices/hotkey.tsLength of output: 73
Action Required: Cross-Platform Clipboard Shortcut Verification
The current implementation sets up clipboard event handling through
installHotKeyForMainWindow(clipboard.value)using theMod+candMod+vshortcuts. As these should translate to Ctrl+C/Ctrl+V on Windows/Linux and Cmd+C/Cmd+V on macOS, please ensure through manual testing that:
- The clipboard functionality behaves correctly on Windows, macOS, and Linux.
- In case this is used in a web context, verify the behavior in all supported browsers.
- Any potential edge cases (e.g., alternative input methods or unexpected focus behavior) are handled properly.
Since the recent automated code search for platform-specific key handling in the hotkey module did not return any results, a detailed manual test across environments is recommended to confirm that the current implementation meets the intended cross-platform requirements.
説明 / Description
#1114
特定の操作をしたときに Ctrl+C (Cmd+C) や Ctrl+V (Cmd+V) が効かなくなる問題への回避策を施す。
チェックリスト / Checklist
npm testpassednpm run lintwas applied without warnings/docs/webappnot included (except release branch)console.lognot included (except script file)Summary by CodeRabbit