Release v1.21.2 and v1.20.6 #1129
Conversation
WalkthroughThis pull request updates version numbers and corresponding URLs in documentation and release files. Multiple HTML and JSON files now reference the upgraded release versions. Several JavaScript modules had their import paths updated, and associated CSS assets were revised—including the addition of a new ErrorMessage stylesheet and deletion of an older one. In addition, a new hidden clipboard functionality was introduced in the renderer application and a new CSS rule was added for dialogs without a backdrop. The package version has been incremented accordingly. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant A as App.vue
participant S as Store
U->>A: Trigger Copy Hotkey
A->>S: call copyRecordKIF()
S-->>A: Copy operation completes
U->>A: Trigger Paste Hotkey
A->>S: call showPasteDialog()
S-->>A: Paste dialog displayed
Possibly related PRs
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
==========================================
+ Coverage 78.48% 79.51% +1.03%
==========================================
Files 122 122
Lines 15918 16108 +190
Branches 2607 2785 +178
==========================================
+ Hits 12493 12809 +316
+ Misses 3406 3280 -126
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/renderer/css/dialog.css (1)
16-18: Add CSS Rule for Dialog Without Backdrop
A new CSS rule for.dialog-no-backdrop dialog::backdrophas been introduced to set the backdrop to fully transparent. This addition increases styling flexibility for dialogs that require no backdrop. Consider adding a brief inline comment for future maintainers describing when to use this class if it's not already documented elsewhere.docs/webapp/assets/main-LeBgv7Ax.css (1)
1-2: Extensive CSS Update.
This stylesheet has been comprehensively updated to adjust the appearance of various UI components (e.g.,.frame,.board,.clock, etc.). Please verify that these style changes produce the intended visual outcome across all supported browsers and devices. For long-term maintainability, consider a modular approach if you expect further style adjustments.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (36)
docs/index.en.html(1 hunks)docs/index.html(1 hunks)docs/index.zh_tw.html(1 hunks)docs/release-linux.json(1 hunks)docs/release-mac.json(1 hunks)docs/release-win.json(1 hunks)docs/release.json(1 hunks)docs/webapp-dev/assets/ErrorMessage-ChGB6vXg.css(1 hunks)docs/webapp-dev/assets/ErrorMessage-zS5oJxQS.css(0 hunks)docs/webapp-dev/assets/InfoMessage-Cw8WO-Me.js(1 hunks)docs/webapp-dev/assets/en-rjHB1Cvr.js(1 hunks)docs/webapp-dev/assets/ja-CTqP16rb.js(1 hunks)docs/webapp-dev/assets/layout-manager-CGMNsf6d.js(1 hunks)docs/webapp-dev/assets/main-LeBgv7Ax.css(1 hunks)docs/webapp-dev/assets/monitor-CYsdAx2G.js(1 hunks)docs/webapp-dev/assets/zh-tw-Bvxpdt_1.js(1 hunks)docs/webapp-dev/index.html(2 hunks)docs/webapp-dev/layout-manager.html(2 hunks)docs/webapp-dev/monitor.html(2 hunks)docs/webapp-dev/prompt.html(1 hunks)docs/webapp/assets/ErrorMessage-ChGB6vXg.css(1 hunks)docs/webapp/assets/ErrorMessage-zS5oJxQS.css(0 hunks)docs/webapp/assets/InfoMessage-Cw8WO-Me.js(1 hunks)docs/webapp/assets/en-rjHB1Cvr.js(1 hunks)docs/webapp/assets/ja-CTqP16rb.js(1 hunks)docs/webapp/assets/layout-manager-CGMNsf6d.js(1 hunks)docs/webapp/assets/main-LeBgv7Ax.css(1 hunks)docs/webapp/assets/monitor-CYsdAx2G.js(1 hunks)docs/webapp/assets/zh-tw-Bvxpdt_1.js(1 hunks)docs/webapp/index.html(2 hunks)docs/webapp/layout-manager.html(2 hunks)docs/webapp/monitor.html(2 hunks)docs/webapp/prompt.html(1 hunks)package.json(1 hunks)src/renderer/App.vue(2 hunks)src/renderer/css/dialog.css(1 hunks)
💤 Files with no reviewable changes (2)
- docs/webapp/assets/ErrorMessage-zS5oJxQS.css
- docs/webapp-dev/assets/ErrorMessage-zS5oJxQS.css
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (60)
docs/webapp/assets/en-rjHB1Cvr.js (1)
1-2: Import Source Update: Verify new module referenceThe import statement now uses
main-yVhprVLP.jsinstead of the previousmain-DUBE5uVF.js, which aligns with the new release configuration. Ensure that the new module file exists and exposes the expected API.package.json (1)
3-3: Version Bump ConfirmedThe package version has been updated to
"1.21.2", consistent with the release objectives. Please verify that all dependent documentation and release notes correctly reference this new version.docs/webapp/prompt.html (1)
30-32: Updated Global Version ReferenceThe
window.electronShogiobject’sappVersionproperty is now"1.21.2"reflecting the latest release update. This change is straightforward, but make sure it meshes with any downstream version checks in the webapp.docs/webapp-dev/prompt.html (1)
29-32: Consistent Version Update in Dev EnvironmentThe update of
appVersionto"1.21.2"in this development-specific prompt HTML is consistent with the main webapp version. Ensure that your development build process recognizes this change.docs/index.html (2)
160-162: Latest Release Link UpdateThe link for the latest version now points to
v1.21.2and the label “最新版 (Version 1.21.2)” has been updated accordingly. Please confirm that this URL correctly references the newly released version.
165-167: Stable Release Link UpdateThe stable version link now correctly points to
v1.20.6and is labeled “安定版 (Version 1.20.6)”. This dual-version release strategy is noted; verify that the documentation clearly differentiates between the latest and stable release channels.docs/webapp-dev/assets/monitor-CYsdAx2G.js (1)
1-2: Update ErrorMessage Import Path
The import statement now uses./ErrorMessage-BFPF08DQ.jsinstead of the older version. This change is in line with the release update requirements and ensures consistency across modules.docs/webapp-dev/assets/ja-CTqP16rb.js (1)
1-2: Update Main Module Import Path
The module import has been updated frommain-DUBE5uVF.jstomain-yVhprVLP.js. This change aligns the file with other similar updates in the project. Please verify that all dependent modules are using the correct path.docs/index.en.html (1)
159-166: Update Version Links for Release
The anchor tags for the Latest and Stable releases have been updated to point to version 1.21.2 and 1.20.6 respectively. This change ensures that the documentation reflects the current release information consistently.docs/webapp/assets/monitor-CYsdAx2G.js (1)
1-2: Update ErrorMessage Import Path in Webapp Assets
Similar to the update in the development assets, this file now imports the ErrorMessage module from./ErrorMessage-BFPF08DQ.js. This maintains consistency across the codebase. Make sure that this change does not affect other parts of the module dependencies.docs/webapp-dev/assets/en-rjHB1Cvr.js (1)
1-2: Import Module Update Verification
The import statement has been updated to use the new module filemain-yVhprVLP.js. Please verify that the alias mapping (i.e.,g as _) and the exported API remain compatible with the rest of the file.docs/webapp/assets/ja-CTqP16rb.js (1)
1-2: Consistent Module Import Path Update
The import has been modified from the old module source tomain-yVhprVLP.js, aligning with updated dependencies across language files. Please ensure that the updated module’s API (usingr as uandg as Y) continues to function as expected.docs/webapp/assets/zh-tw-Bvxpdt_1.js (1)
1-2: Module Import Update Check
The import statement now referencesmain-yVhprVLP.jsinstead ofmain-DUBE5uVF.js, with aliases maintained asr as Yandg as m. Confirm that these changes do not impact the expected functionality or locale initialization in this file.docs/webapp-dev/assets/main-LeBgv7Ax.css (1)
1-2: Comprehensive CSS Update Review
This complete replacement of the CSS file introduces updated style definitions for a wide range of UI components. All selectors and CSS variables (e.g.,--text-color,--main-bg-color) appear consistently defined. Ensure that these styles have been cross-tested across target browsers and devices to maintain layout and visual consistency.docs/webapp-dev/assets/InfoMessage-Cw8WO-Me.js (1)
1-3: ErrorMessage Module Import Update
The import for the ErrorMessage functionality has changed fromErrorMessage-DBx_I8IT.jstoErrorMessage-BFPF08DQ.js. Please verify that the new module’s interface (imported as{ s as F, i as M, u as N, I as V, _ as $ }) aligns correctly with its usage in the InfoMessage component and that no downstream behavior is affected.docs/webapp/monitor.html (4)
12-12: Updated Monitor Script Reference
The module script now references./assets/monitor-CYsdAx2G.jswhich aligns with the new release version.
13-14: Updated ErrorMessage Module Preload Link
The preload link for the ErrorMessage module has been updated to./assets/ErrorMessage-BFPF08DQ.js. This change appears consistent with the new release resources.
17-18: Updated ErrorMessage Stylesheet Reference
The stylesheet link now points to./assets/ErrorMessage-ChGB6vXg.css, ensuring that the latest error message styles are applied.
31-32: Updated Application Version
The application version has been updated to"1.21.2"in the JavaScript object. This correctly reflects the release changes.docs/webapp/assets/ErrorMessage-ChGB6vXg.css (1)
1-2: New CSS File for ErrorMessage Styling
The new stylesheet defines comprehensive dialog styles using CSS variables and flex properties. The implementation is efficient and consistent with the project’s theming, ensuring a modern and maintainable design.docs/webapp-dev/assets/zh-tw-Bvxpdt_1.js (1)
1-1: Updated Module Import for Localization
The import statement has been updated to use"./main-yVhprVLP.js"instead of the previous module. This change is in line with parallel updates in other localized asset files and ensures consistency across the codebase.docs/webapp-dev/monitor.html (4)
12-12: Updated Monitor Script Reference
The module script is now loaded from./assets/monitor-CYsdAx2G.js, which correctly reflects the updated asset version for this release.
13-14: Updated ErrorMessage Module Preload Link
The preload link for ErrorMessage now uses./assets/ErrorMessage-BFPF08DQ.js. This update brings consistency with the new asset naming conventions.
17-18: Updated ErrorMessage Stylesheet Reference
The stylesheet reference is updated to./assets/ErrorMessage-ChGB6vXg.css, ensuring that the updated styling is applied to dialogs.
31-32: Updated Application Version
The JavaScript object now reflectsappVersion: "1.21.2", which is aligned with the overall release version update.docs/webapp/index.html (5)
12-12: Updated Main Script Reference
The main script source has been updated to./assets/main-yVhprVLP.js, aligning with the new release assets.
13-14: Updated ErrorMessage Module Preload Link
The preload link for ErrorMessage is now./assets/ErrorMessage-BFPF08DQ.js, which is consistent with the asset updates seen elsewhere in the project.
17-19: Updated InfoMessage Module Preload Link
The InfoMessage module preload link has been updated to./assets/InfoMessage-Cw8WO-Me.js. This update ensures that the correct version of the InfoMessage asset is loaded.
24-25: Updated Main Stylesheet Reference
The main stylesheet link now points to./assets/main-LeBgv7Ax.css, reflecting the updated styles associated with the new release.
36-37: Updated Application Version
The embedded JavaScript now declaresappVersion: "1.21.2", confirming the version bump.docs/webapp/assets/InfoMessage-Cw8WO-Me.js (1)
1-3: Updated ErrorMessage Module Import.
The import statement now references./ErrorMessage-BFPF08DQ.jsinstead of the old path. This aligns with the new release changes and ensures consistency across the project’s modules.docs/webapp-dev/assets/ErrorMessage-ChGB6vXg.css (1)
1-2: New ErrorMessage CSS File Added.
The newly introduced stylesheet defines comprehensive styles for dialog components, following the updated design guidelines. Make sure that all HTML files referring to the ErrorMessage styling have been updated accordingly.docs/webapp/layout-manager.html (4)
12-12: Layout Manager Script Update.
The script source has been updated to"./assets/layout-manager-CGMNsf6d.js", which aligns with the new release version.
14-16: Module Preload References Updated.
The preload links forErrorMessageandInfoMessagenow point to their updated files (ErrorMessage-BFPF08DQ.jsandInfoMessage-Cw8WO-Me.js). This change ensures that the correct module versions are fetched during runtime.
17-18: Stylesheet Reference Update.
The link now loads the updated ErrorMessage CSS from"./assets/ErrorMessage-ChGB6vXg.css", which guarantees that the new styling is applied uniformly.
32-33: Application Version Bumped.
TheappVersionhas been updated to"1.21.2", ensuring that the document correctly reflects the latest release version.docs/webapp-dev/layout-manager.html (4)
12-12: Layout Manager Script Update.
The updated script source ("./assets/layout-manager-CGMNsf6d.js") confirms that the latest version of the layout manager is now being used.
13-16: Module Preload Links Refreshed.
BothErrorMessageandInfoMessagemodules are now preloaded from their new paths, ensuring that updated resources are utilized at runtime.
17-18: ErrorMessage Stylesheet Updated.
The CSS reference is updated to"./assets/ErrorMessage-ChGB6vXg.css", which aligns with the new design and module versioning introduced in this release.
32-33: Application Version Consistency.
TheappVersionin the embedded script is now set to"1.21.2", matching the overall release version across the project.docs/webapp-dev/index.html (4)
12-12: Version update: Script source updatedThe script source has been updated to reflect the new build for version 1.21.2.
14-14: Version update: Module preload references updatedThe modulepreload references for ErrorMessage and InfoMessage components have been updated to their new file hashes, which is expected during a version update.
Also applies to: 19-19
21-21: Version update: Stylesheet references updatedThe stylesheet references for ErrorMessage and the main stylesheet have been updated to their new file hashes, consistent with the version update.
Also applies to: 25-25
37-37: Version increment from 1.21.1 to 1.21.2The application version has been properly incremented, which matches the PR objective for release v1.21.2.
src/renderer/App.vue (5)
55-60: New clipboard functionality implemented via hidden buttonsHidden buttons with hotkey attributes have been added to address clipboard event handling issues referenced in GitHub issue #1114. This approach uses the hotkey library to capture standard Ctrl+C/Cmd+C and Ctrl+V/Cmd+V keyboard shortcuts.
65-65: Added necessary imports for clipboard functionalityThe
refimport from Vue and theinstallHotKeyForMainWindowfunction have been appropriately imported to support the new clipboard functionality.Also applies to: 103-103
105-105: Added clipboard ref for DOM accessA Vue reference has been created to access the clipboard container DOM element.
113-119: Added clipboard event handler methodsNew methods
onCopyandonPastehave been implemented to handle the clipboard operations, calling the appropriate store methods when triggered by keyboard shortcuts.
122-122: Initialized hotkey functionality in onMounted hookThe
installHotKeyForMainWindowfunction is now called with the clipboard DOM element reference during component mount, properly setting up the hotkey functionality.docs/index.zh_tw.html (2)
164-166: Updated latest version link to v1.21.2The link for the latest version has been updated from v1.21.1 to v1.21.2, consistent with the new release.
169-171: Updated stable version link to v1.20.6The link for the stable version has been updated from v1.20.5 to v1.20.6, consistent with the new release.
docs/release.json (1)
1-12: Updated version information in release.jsonThe version information has been properly updated:
- Stable version from 1.20.5 to 1.20.6
- Latest version from 1.21.1 to 1.21.2
All corresponding tags and links have been updated consistently to point to the correct release tags on GitHub.
docs/release-mac.json (2)
3-5: Version update reflects stable release increment.The stable version has been properly updated from 1.20.5 to 1.20.6, with corresponding tag and link modifications that maintain consistency.
8-10: Version update reflects latest release increment.The latest version has been properly updated from 1.21.1 to 1.21.2, with corresponding tag and link modifications that maintain consistency.
docs/webapp/assets/layout-manager-CGMNsf6d.js (1)
1-1: Module import paths updated appropriately.The import paths for ErrorMessage and InfoMessage modules have been updated to their new versions:
- ErrorMessage: from
ErrorMessage-DBx_I8IT.jstoErrorMessage-BFPF08DQ.js- InfoMessage: from
InfoMessage-DilJSC6G.jstoInfoMessage-Cw8WO-Me.jsThese changes are consistent with the version updates in this release.
docs/webapp-dev/assets/layout-manager-CGMNsf6d.js (1)
1-1: Module import paths updated consistently with production version.The development version has the same import path updates as the production version:
- ErrorMessage: from
ErrorMessage-DBx_I8IT.jstoErrorMessage-BFPF08DQ.js- InfoMessage: from
InfoMessage-DilJSC6G.jstoInfoMessage-Cw8WO-Me.jsThis ensures consistency between development and production environments.
docs/release-win.json (2)
3-5: Windows stable version updated consistently with other platforms.The stable version has been properly updated from 1.20.5 to 1.20.6, with corresponding tag and link modifications, maintaining cross-platform version consistency.
8-10: Windows latest version updated consistently with other platforms.The latest version has been properly updated from 1.21.1 to 1.21.2, with corresponding tag and link modifications, maintaining cross-platform version consistency.
docs/release-linux.json (2)
3-5: Update Stable Release Information
The stable release information is correctly updated to version 1.20.6 with the appropriate tag and release link. Please verify that these updates are aligned with the rest of the release documentation.
8-10: Update Latest Release Information
The latest release entries are correctly updated to version 1.21.2. Ensure that all other documentation files referencing this release are synchronized with these changes.
説明 / Description
Release v1.21.2 and v1.20.6
チェックリスト / Checklist
npm testpassednpm run lintwas applied without warnings/docs/webappnot included (except release branch)console.lognot included (except script file)Summary by CodeRabbit
Documentation
Style
New Features