Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't link to regex_macros at runtime. #3

Merged
merged 1 commit into from
Feb 4, 2015

Conversation

BurntSushi
Copy link
Contributor

Fixes #2.

You may also want to consider moving to plain regex since regex_macros won't work in the stable channel of Rust 1.0. (We may come up with a fix before then using build.rs though.)

@sunng87
Copy link
Owner

sunng87 commented Feb 4, 2015

Thanks for the patch! I will move to regex later.

sunng87 added a commit that referenced this pull request Feb 4, 2015
Don't link to regex_macros at runtime.
@sunng87 sunng87 merged commit e5b1fed into sunng87:master Feb 4, 2015
@sunng87
Copy link
Owner

sunng87 commented Feb 5, 2015

Just an update:

There seems no way to create regexp constant without using regex!. So I may need to keep regex_macros until I get a solution.

@sunng87 sunng87 mentioned this pull request Aug 28, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A problem with regex_macros
2 participants